From bf634b822414f42e19eba138bda919bd70a4cf24 Mon Sep 17 00:00:00 2001
From: Ted Unangst <tedu@tedunangst.com>
Date: Thu, 25 Apr 2019 01:18:39 -0400
Subject: [PATCH] don't fetch bonks if we already have them

---
 activity.go | 22 ++++++++++++++++------
 honk.go     |  4 ++--
 2 files changed, 18 insertions(+), 8 deletions(-)

diff --git a/activity.go b/activity.go
index dae835e..a560c21 100644
--- a/activity.go
+++ b/activity.go
@@ -227,14 +227,21 @@ func savedonk(url string, name, media string) *Donk {
 }
 
 func needxonk(user *WhatAbout, x *Honk) bool {
-	if strings.HasPrefix(x.XID, user.URL+"/h/") {
+	if x == nil {
 		return false
 	}
 	if x.What == "eradicate" {
 		return true
 	}
-	row := stmtFindXonk.QueryRow(user.ID, x.XID)
-	err := row.Scan(&x.ID)
+	return needxonkid(user, x.XID)
+}
+func needxonkid(user *WhatAbout, xid string) bool {
+	if strings.HasPrefix(xid, user.URL+"/h/") {
+		return false
+	}
+	row := stmtFindXonk.QueryRow(user.ID, xid)
+	var id int64
+	err := row.Scan(&id)
 	if err == nil {
 		return false
 	}
@@ -361,8 +368,8 @@ func peeppeep() {
 			}
 
 			for _, item := range items {
-				xonk := xonkxonk(item)
-				if xonk != nil && needxonk(user, xonk) {
+				xonk := xonkxonk(user, item)
+				if needxonk(user, xonk) {
 					xonk.UserID = user.ID
 					savexonk(user, xonk)
 				}
@@ -401,7 +408,7 @@ func newphone(a []string, obj map[string]interface{}) []string {
 	return a
 }
 
-func xonkxonk(item interface{}) *Honk {
+func xonkxonk(user *WhatAbout, item interface{}) *Honk {
 	// id, _ := jsongetstring(item, "id")
 	what, _ := jsongetstring(item, "type")
 	dt, _ := jsongetstring(item, "published")
@@ -415,6 +422,9 @@ func xonkxonk(item interface{}) *Honk {
 	case "Announce":
 		xid, ok = jsongetstring(item, "object")
 		if ok {
+			if !needxonkid(user, xid) {
+				return nil
+			}
 			log.Printf("getting bonk: %s", xid)
 			obj, err = GetJunk(xid)
 			if err != nil {
diff --git a/honk.go b/honk.go
index 5e0d9cf..76bc434 100644
--- a/honk.go
+++ b/honk.go
@@ -365,8 +365,8 @@ func inbox(w http.ResponseWriter, r *http.Request) {
 			}
 		}
 	default:
-		xonk := xonkxonk(j)
-		if xonk != nil && needxonk(user, xonk) {
+		xonk := xonkxonk(user, j)
+		if needxonk(user, xonk) {
 			xonk.UserID = user.ID
 			savexonk(user, xonk)
 		}