dirk
/
why-cant-we-deploy-today
1
0
Fork 0
Code Releases Activity

fix issue with #3182 when slide numbers are disabled

This commit is contained in:
hakimel 2022-04-04 15:33:44 +02:00
parent fca5b33530
commit 1767e76cdc
5 changed files with 16 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
dist/reveal.esm.js vendored
View File

File diff suppressed because one or more lines are too long

2
dist/reveal.esm.js.map vendored
View File

File diff suppressed because one or more lines are too long

2
dist/reveal.js vendored
View File

File diff suppressed because one or more lines are too long

2
dist/reveal.js.map vendored
View File

File diff suppressed because one or more lines are too long

20
js/controllers/print.js
View File

@ -22,7 +22,7 @@ export default class Print {
const slides = queryAll( this.Reveal.getRevealElement(), SLIDES_SELECTOR ) const slides = queryAll( this.Reveal.getRevealElement(), SLIDES_SELECTOR )
// Compute slide numbers now, before we start duplicating slides // Compute slide numbers now, before we start duplicating slides
const doingSlideNumbers = config.slideNumber && /all|print/i.test( config.showSlideNumber ); const injectPageNumbers = config.slideNumber && /all|print/i.test( config.showSlideNumber );
const slideSize = this.Reveal.getComputedSlideSize( window.innerWidth, window.innerHeight ); const slideSize = this.Reveal.getComputedSlideSize( window.innerWidth, window.innerHeight );
@ -147,13 +147,12 @@ export default class Print {
} }
// Inject slide numbers if `slideNumbers` are enabled // Inject page numbers if `slideNumbers` are enabled
if( doingSlideNumbers ) { if( injectPageNumbers ) {
const numberElement = document.createElement( 'div' ); const numberElement = document.createElement( 'div' );
numberElement.classList.add( 'slide-number' ); numberElement.classList.add( 'slide-number' );
numberElement.classList.add( 'slide-number-pdf' ); numberElement.classList.add( 'slide-number-pdf' );
numberElement.innerHTML = slideNumber; numberElement.innerHTML = slideNumber++;
slideNumber++;
page.appendChild( numberElement ); page.appendChild( numberElement );
} }
@ -183,9 +182,14 @@ export default class Print {
// Create a separate page for the current fragment state // Create a separate page for the current fragment state
const clonedPage = page.cloneNode( true ); const clonedPage = page.cloneNode( true );
const numberElement = clonedPage.querySelector( '.slide-number-pdf' );
const fragmentNumber = index + 1; // Inject unique page numbers for fragments
numberElement.innerHTML = numberElement.innerHTML + "." + fragmentNumber; if( injectPageNumbers ) {
const numberElement = clonedPage.querySelector( '.slide-number-pdf' );
const fragmentNumber = index + 1;
numberElement.innerHTML += '.' + fragmentNumber;
}
pages.push( clonedPage ); pages.push( clonedPage );
previousFragmentStep = fragments; previousFragmentStep = fragments;