dirk
/
why-cant-we-deploy-today
1
0
Fork 0
Code Releases Activity

fix issues with overflowing fit-text when exporting to pdf #3191 #3120

This commit is contained in:
hakimel 2022-05-31 11:50:26 +02:00
parent a3f4caf179
commit 5a031c07b6
8 changed files with 12 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
css/print/pdf.scss
View File

@ -96,10 +96,6 @@ html.print-pdf {
min-height: auto !important; min-height: auto !important;
} }
.reveal .r-fit-text {
white-space: normal !important;
}
.reveal img { .reveal img {
box-shadow: none; box-shadow: none;
} }

2
dist/reveal.css vendored
View File

File diff suppressed because one or more lines are too long

2
dist/reveal.esm.js vendored
View File

File diff suppressed because one or more lines are too long

2
dist/reveal.esm.js.map vendored
View File

File diff suppressed because one or more lines are too long

2
dist/reveal.js vendored
View File

File diff suppressed because one or more lines are too long

2
dist/reveal.js.map vendored
View File

File diff suppressed because one or more lines are too long

7
js/controllers/print.js
View File

@ -110,9 +110,7 @@ export default class Print {
slide.style.top = top + 'px'; slide.style.top = top + 'px';
slide.style.width = slideWidth + 'px'; slide.style.width = slideWidth + 'px';
// Re-run the slide layout so that r-fit-text is applied based on this.Reveal.slideContent.layout( slide );
// the printed slide size
this.Reveal.slideContent.layout( slide )
if( slide.slideBackgroundElement ) { if( slide.slideBackgroundElement ) {
page.insertBefore( slide.slideBackgroundElement, slide ); page.insertBefore( slide.slideBackgroundElement, slide );
@ -219,6 +217,9 @@ export default class Print {
pages.forEach( page => pageContainer.appendChild( page ) ); pages.forEach( page => pageContainer.appendChild( page ) );
// Re-run JS-based content layout after the slide is added to page DOM
this.Reveal.slideContent.layout( this.Reveal.getSlidesElement() );
// Notify subscribers that the PDF layout is good to go // Notify subscribers that the PDF layout is good to go
this.Reveal.dispatchEvent({ type: 'pdf-ready' }); this.Reveal.dispatchEvent({ type: 'pdf-ready' });

7
js/controllers/slidecontent.js
View File

@ -186,15 +186,14 @@ export default class SlideContent {
} }
/** /**
* Applies JS-dependent layout helpers for the given slide, * Applies JS-dependent layout helpers for the scope.
* if there are any.
*/ */
layout( slide ) { layout( scopeElement ) {
// Autosize text with the r-fit-text class based on the // Autosize text with the r-fit-text class based on the
// size of its container. This needs to happen after the // size of its container. This needs to happen after the
// slide is visible in order to measure the text. // slide is visible in order to measure the text.
Array.from( slide.querySelectorAll( '.r-fit-text' ) ).forEach( element => { Array.from( scopeElement.querySelectorAll( '.r-fit-text' ) ).forEach( element => {
fitty( element, { fitty( element, {
minSize: 24, minSize: 24,
maxSize: this.Reveal.getConfig().height * 0.8, maxSize: this.Reveal.getConfig().height * 0.8,